Skip to content

Conversation

@matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Jul 3, 2025

What does this PR do?

Fixes #20954

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20961.org.readthedocs.build/en/20961/

@github-actions github-actions bot added the ci Continuous Integration label Jul 3, 2025
Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets revisit also all development script to e using uv since in guide we recommend to use UV we shall not have colision as then you shall not call python ... but uv run ...

@Borda Borda merged commit b087c1a into Lightning-AI:master Jul 9, 2025
12 of 14 checks passed
@matsumotosan matsumotosan deleted the contributing-steps branch July 9, 2025 12:17
Borda pushed a commit that referenced this pull request Aug 13, 2025
(cherry picked from commit b087c1a)
Borda pushed a commit that referenced this pull request Aug 13, 2025
(cherry picked from commit b087c1a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recommend dev setup / support uv

5 participants